Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name for equilibrium reaction CPLX0-7796_RXN in rates file #1080

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

ggsun
Copy link
Contributor

@ggsun ggsun commented Jun 1, 2021

This PR fixes a reaction name in reconstruction/ecoli/flat/equilibrium_reaction_rates.tsv to match the manual name change to the reaction made in PR #1065. Without this fix the rate of the reaction CPLX0-7796_EQUILIBRIUM_RXN was set to be default values (median of all listed rates) which affected the active% of the transcription factor under both active and inactive conditions. This fix should bring those values back to what they were before the merge.

Copy link
Member

@tahorst tahorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a way to check that data files like this match something before and after an update to the files from EcoCyc? I feel like automating a check to see if we're dropping or able to add any data with a new flat file version would be nice to have.

@ggsun
Copy link
Contributor Author

ggsun commented Jun 2, 2021

Should we add a way to check that data files like this match something before and after an update to the files from EcoCyc? I feel like automating a check to see if we're dropping or able to add any data with a new flat file version would be nice to have.

This is a good idea. I'll add this to the list of TODOs on issue #1067. There were other files where rows had to be skipped since the IDs used weren't present in the new files anymore.

@ggsun ggsun merged commit d388249 into master Jun 2, 2021
@ggsun ggsun deleted the fix-ecocyc-equilibrium-rates branch June 2, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants