Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DragonConnector refactor #591

Open
al-rigazzi opened this issue May 20, 2024 · 0 comments
Open

DragonConnector refactor #591

al-rigazzi opened this issue May 20, 2024 · 0 comments
Labels
area: Dragon area: launcher Issues related to any of the launchers within SmartSim repo: smartsim Issues related to SmartSim infrastructure library type: refactor Issues focused on refactoring existing code

Comments

@al-rigazzi
Copy link
Collaborator

Description

The DragonConnector class should be refactored to ensure maintainability and readability.

Justification

The DragonConnector class contains at least one monolithic method, connect_to_dragon that is deeply nested and complex to read or maintain. Moreover, the class has too many responsibilities and should be split up in simpler, single-responsibility classes.

Implementation Strategy

The refactor should aim at reducing complexity, most likely by adding new single-responsibility objects, and splitting up nested and long methods.

@al-rigazzi al-rigazzi added area: Dragon area: launcher Issues related to any of the launchers within SmartSim repo: smartsim Issues related to SmartSim infrastructure library type: refactor Issues focused on refactoring existing code labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Dragon area: launcher Issues related to any of the launchers within SmartSim repo: smartsim Issues related to SmartSim infrastructure library type: refactor Issues focused on refactoring existing code
Projects
None yet
Development

No branches or pull requests

1 participant