Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use templates for batch scripts #596

Open
al-rigazzi opened this issue May 21, 2024 · 0 comments
Open

Use templates for batch scripts #596

al-rigazzi opened this issue May 21, 2024 · 0 comments
Labels
area: job Issues related to job management repo: smartsim Issues related to SmartSim infrastructure library type: feature Issues that include feature request or feature idea type: refactor Issues focused on refactoring existing code

Comments

@al-rigazzi
Copy link
Collaborator

Description

Templates should be used by _write_xxx_script methods.

Justification

Currently, batch scripts are written programmatically, line by line, in Step functions such as _write_sbatch_script. The usage of templates would be more indicated, as the content of such scripts is pretty standard.

Implementation Strategy

Templates should be used to replace the current line-by-line functions.
@al-rigazzi al-rigazzi added area: job Issues related to job management repo: smartsim Issues related to SmartSim infrastructure library type: feature Issues that include feature request or feature idea type: refactor Issues focused on refactoring existing code labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: job Issues related to job management repo: smartsim Issues related to SmartSim infrastructure library type: feature Issues that include feature request or feature idea type: refactor Issues focused on refactoring existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@al-rigazzi