Automatic update of Microsoft.CodeAnalysis.FxCopAnalyzers to 3.3.0 (N…

…uKeeperDotNet#1022) * 📦 Automatic update of Microsoft.CodeAnalysis.FxCopAnalyzers to 3.3.0 * Fix errors flagged by analysis
CrispyDrone · Sep 1, 2020 · bc44d08 · bc44d08
1 parent 7ab8e2c
commit bc44d08
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 10 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -16,6 +16,6 @@
     <RepositoryUrl>https://github.com/NuKeeperDotNet/NuKeeper.git</RepositoryUrl>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.0.0" PrivateAssets="All" />
+    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.0" PrivateAssets="All" />
   </ItemGroup>
-</Project>
+</Project>
diff --git a/NuKeeper.Abstractions.Tests/Configuration/FileSettingsReaderTests.cs b/NuKeeper.Abstractions.Tests/Configuration/FileSettingsReaderTests.cs
@@ -13,7 +13,7 @@ namespace NuKeeper.Abstractions.Tests.Configuration
     [TestFixture]
     public class FileSettingsReaderTests
     {
-        private string _uniqueTemporaryFolder = null;
+        private string _uniqueTemporaryFolder;
 
         [SetUp]
         public void Setup()

diff --git a/NuKeeper.Inspection.Tests/Sources/NugetSourcesReaderTests.cs b/NuKeeper.Inspection.Tests/Sources/NugetSourcesReaderTests.cs
@@ -15,7 +15,7 @@ namespace NuKeeper.Inspection.Tests.Sources
 {
     public class NugetSourcesReaderTests
     {
-        private IFolder _uniqueTemporaryFolder = null;
+        private IFolder _uniqueTemporaryFolder;
 
         [SetUp] 
         public void Setup()

diff --git a/NuKeeper.Integration.Tests/LogHelpers/NuKeeperTestLogger.cs b/NuKeeper.Integration.Tests/LogHelpers/NuKeeperTestLogger.cs
@@ -26,7 +26,7 @@ public void DumpLogToTestOutput()
         {
             var test = TestContext.CurrentContext.Test.Name;
 
-            if (_buffer.Count > 0)
+            if (!_buffer.IsEmpty)
             {
                 TestContext.Error.WriteLine($"{test}: NuKeeper Log:");
                 while (_buffer.TryDequeue(out var line))

diff --git a/NuKeeper.Integration.Tests/LogHelpers/NugetTestLogger.cs b/NuKeeper.Integration.Tests/LogHelpers/NugetTestLogger.cs
@@ -26,7 +26,7 @@ public void DumpLogToTestOutput()
         {
             var test = TestContext.CurrentContext.Test.Name;
 
-            if (_buffer.Count > 0)
+            if (!_buffer.IsEmpty)
             {
                 TestContext.Error.WriteLine($"{test}: NuKeeper Log:");
                 while (_buffer.TryDequeue(out var line))

diff --git a/NuKeeper.Integration.Tests/NuGet/Process/DotNetUpdatePackageCommandTests.cs b/NuKeeper.Integration.Tests/NuGet/Process/DotNetUpdatePackageCommandTests.cs
@@ -63,7 +63,7 @@ public class DotNetUpdatePackageCommandTests : TestWithFailureLogging
   <Import Project=""$(MSBuildToolsPath)\Microsoft.CSharp.targets"" />
 </Project>";
 
-        private IFolder _uniqueTemporaryFolder = null;
+        private IFolder _uniqueTemporaryFolder;
 
         [SetUp]
         public void Setup()

diff --git a/NuKeeper.Integration.Tests/NuGet/Process/NuGetUpdatePackageCommandTests.cs b/NuKeeper.Integration.Tests/NuGet/Process/NuGetUpdatePackageCommandTests.cs
@@ -31,7 +31,7 @@ public class NuGetUpdatePackageCommandTests : TestWithFailureLogging
         private readonly string _nugetConfig =
             @"<configuration><config><add key=""repositoryPath"" value="".\packages"" /></config></configuration>";
 
-        private IFolder _uniqueTemporaryFolder = null;
+        private IFolder _uniqueTemporaryFolder;
 
         [SetUp]
         public void Setup()

diff --git a/NuKeeper.Integration.Tests/RepositoryInspection/RepositoryScannerTests.cs b/NuKeeper.Integration.Tests/RepositoryInspection/RepositoryScannerTests.cs
@@ -48,7 +48,7 @@ public class RepositoryScannerTests : TestWithFailureLogging
   </ItemGroup>
 </Project>";
 
-        private IFolder _uniqueTemporaryFolder = null;
+        private IFolder _uniqueTemporaryFolder;
 
         [SetUp]
         public void Setup()

diff --git a/NuKeeper.Update/Selection/UpdateSelection.cs b/NuKeeper.Update/Selection/UpdateSelection.cs
@@ -12,7 +12,7 @@ public class UpdateSelection : IUpdateSelection
     {
         private readonly INuKeeperLogger _logger;
         private FilterSettings _settings;
-        private DateTime? _maxPublishedDate = null;
+        private DateTime? _maxPublishedDate;
 
         public UpdateSelection(INuKeeperLogger logger)
         {