Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete item from inner collection in onDelete #12

Open
mtychyna opened this issue Apr 27, 2016 · 1 comment
Open

Delete item from inner collection in onDelete #12

mtychyna opened this issue Apr 27, 2016 · 1 comment

Comments

@mtychyna
Copy link

After onDelete the item is still in inner collection, and it can break business logic.

                deletableView.setOnClickListener(new OnClickListener() {
                    @Override
                    public void onClick(View v) {
                        if (mDeleteListener != null) {
                            Tag targetTag = tag;
                            mDeleteListener.onTagDeleted(TagView.this, targetTag, position);
                        }
                    }
                });

Need delete from inner mTags!

@Cutta
Copy link
Owner

Cutta commented Aug 2, 2016

It depends on you. The library can remove but maybe you want just disappear the tags so if you want to remove from mTags. you can just initiliaze the tag's list which updated one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants