Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDEA] rspack compatibility #1255

Open
PrettyCoffee opened this issue Feb 12, 2024 · 2 comments
Open

[IDEA] rspack compatibility #1255

PrettyCoffee opened this issue Feb 12, 2024 · 2 comments
Labels
enhancement New feature or request idea

Comments

@PrettyCoffee
Copy link

Is your feature request related to a problem? Please describe.

I tried running this plugin in rspack / rsbuild, but am getting the error:

TypeError: Cannot read properties of undefined (reading 'tap')

This, of course, is a webpack plugin and no rspack plugin. However, rspack is a lot more performant than webpack and rspack aims to be webpack plugin compatible. Therefore it would be a nice feature to have rspack compatibility.

Describe the solution you'd like

Compatibility with rspack / rsbuild

Additional context

Unfortunately I don't have any experience with bundler plugins, webpack or rspack. However, if you can point me into a direction where this problem may be originating from and are open to support rspack workarounds, I can check if I can contribute a PR for this. :)

@PrettyCoffee PrettyCoffee added the enhancement New feature or request label Feb 12, 2024
@jkowalleck
Copy link
Member

well, the first step would be to have a reproducible test bed, so see what you've tried and how it behaves.

Could you provide a reproducible test bed as a pullrequest?
The test bed would would be somewhere in https://github.com/CycloneDX/cyclonedx-webpack-plugin/tree/master/tests/integration
You will find several test beds already, just put yours next to it.

@jkowalleck jkowalleck changed the title rspack compatbility [IDEA] rspack compatbility Mar 10, 2024
@jkowalleck jkowalleck changed the title [IDEA] rspack compatbility [IDEA] rspack compatibility Mar 10, 2024
@jkowalleck
Copy link
Member

Since this webpack plugin is a plugin for webpack - it utilizes a lot of webpack internals.
I doubt that it will be compatible at any point.... feel free to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request idea
Projects
None yet
Development

No branches or pull requests

2 participants