Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Line Reference documentation link for ISIS3 is bad #5180

Closed
meganhenriksen opened this issue Apr 12, 2023 · 8 comments
Closed

Command Line Reference documentation link for ISIS3 is bad #5180

meganhenriksen opened this issue Apr 12, 2023 · 8 comments

Comments

@meganhenriksen
Copy link

Description

Under 'Explore in More Detail' page (https://isis.astrogeology.usgs.gov/7.0.0/UserExplore/index.html), the link to the Command Line Reference currently links to:
https://usgs-astrogeology.github.io/ISIS3/ISIS_Cube_Format.html

This is both a bad link and doesn't seem like it would have been correct.

Suggested Edit

Thanks!

@antonhibl
Copy link
Contributor

@meganhenriksen Hi Megan, looks like that link needs to be updated in our documentation; here is the correct link for that: ISIS Cube Format. Thanks for opening up an issue!

@lwellerastro
Copy link
Contributor

lwellerastro commented Apr 12, 2023

The Special Pixels and Base/Multiplier links are broken as well. The Map Definition link sources back to that page's index.html.
Might be worth running through them all.

@meganhenriksen
Copy link
Author

I was actually trying to get to the Command Line Reference, not the ISIS Cube Format, so the Command Line Reference was linking to the wrong thing as well.

@antonhibl
Copy link
Contributor

@meganhenriksen well in any of these broken link cases what you can typically do is replace the usgs-astrogeology in the url with doi-usgs. We will be going through to fix these links for the next release of ISIS.

@meganhenriksen
Copy link
Author

It's difficult to replace without knowing what the correct bad link (if that even makes sense) is. The command line reference probably should link to something like 'Command_Line_Reference.html' and not Isis_Cube_Format.html? (Note: this is not correct even with the doi-usgs). But that would just be me guessing.

In additional several of the links on that page still work and link to something like: Preference Dictionary in which case maybe the correct link is something like: https://isis.astrogeology.usgs.gov/7.0.0/documents/CommandLineReference/CommandLineReference.html (though this doesn't work, I tried)

I know I'm being pendantic, but you can't just do a find/replace with usgs-astrogeology and doi-usgs to fix this so I want to make sure both aspects of this (broken link and wrong thing being linked) are being addressed.

@antonhibl
Copy link
Contributor

@meganhenriksen These issues are going to be addressed in the next release of ISIS. It seems the site you are looking for is https://isis.astrogeology.usgs.gov/documents/CommandLine/CommandLine.html.

@AustinSanders
Copy link
Contributor

@antonhibl Is this closable as of #5182 ?

@antonhibl
Copy link
Contributor

@AustinSanders yes this should be good to close, all the links I was aware of are addressed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants