Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing rclone dependency when running downloadIsisData #5183

Closed
AustinSanders opened this issue Apr 12, 2023 · 2 comments
Closed

Missing rclone dependency when running downloadIsisData #5183

AustinSanders opened this issue Apr 12, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@AustinSanders
Copy link
Contributor

ISIS version(s) affected: 7.1+

Description
rclone is specified as a build dependency, but not a runtime dependency, and scripts like downloadIsisData fail with an "rclone not found" error.

How to reproduce

mamba install -c usgs-astrogeology isis
conda env config vars set ISISROOT=$CONDA_PREFIX
conda deactivate
conda activate isis_test
downloadIsisData all $ISISDATA --dry-run

Possible Solution
add rclone to runtime dependencies in meta.yaml

Additional context

@AustinSanders AustinSanders added the bug Something isn't working label Apr 12, 2023
@antonhibl
Copy link
Contributor

@AustinSanders looks like we can close this; rclone is now listed as a dependency under both builld and run.

@Kelvinrr
Copy link
Collaborator

Kelvinrr commented May 2, 2023

8.0.0 release does indeed download rclone so I think this is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants