Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trimfilter ignores high and low parameters #5311

Closed
rvwagner opened this issue Oct 13, 2023 · 1 comment · Fixed by #5340
Closed

trimfilter ignores high and low parameters #5311

rvwagner opened this issue Oct 13, 2023 · 1 comment · Fixed by #5340
Assignees
Labels
bug Something isn't working

Comments

@rvwagner
Copy link

ISIS version(s) affected: At least 8.0.1, but I think this bug goes back to the very beginning of ISIS3.

Description
The HIGH and LOW parameters of trimfilter don't seem to have any effect

How to reproduce

makecube l=100 s=100 b=1 to=t.cub
fakecube f=t.cub t=gradient.cub
trimfilter from=gradient.cub to=trimfiltered.cub low=75 high=125 minopt=count minimum=9 lines=3 samples=3

Expected result: Everything but a diagonal line from lower-left to upper-right getting nulled out.
Actual result: **USER ERROR** Your selected parameters did not trim any data from the cube in main.cpp at 48.

Workaround to get expected result:

mask from=gradient.cub mask=gradient.cub to=mask.cub mini=75 maxi=125
trimfilter from=mask.cub to=maskfiltered.cub minopt=count minimum=9 lines=3 samples=3

Possible Solution
Looking at the source code, it looks like the LOW and HIGH input parameters are never actually read in; it should be trivial to add them in using whatever the standard syntax is for optional arguments and get everything working, assuming the back-end code functions as expected.

@rvwagner rvwagner added the bug Something isn't working label Oct 13, 2023
@AustinSanders
Copy link
Contributor

@rvwagner Thanks for the report and solution. We're in the process of scheduling a support sprint, and this will likely be resolved during that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants