Unit tests take too long

[oleg-alexandrov]

ISIS version(s) affected: Latest

Description

The unit test DefaultCube.FunctionalTestCamstatsDefaultParameters takes 20 minutes to run. That is a very unreasonable amount of time, and it simply looks that it stalls.

It is suggested not to compute the stats for every line and sample but for only every 10th one, or at least every 5th one, which should make it much faster.

It is also not clear why it takes so long to run the stats, the image there is 1000 x 1000 pixels or so.

[oleg-alexandrov]

There are at least 4 such tests using camera stats. Any time the regression gets there it stalls. Very unhelpful when it comes to updating tests, one has to spend hours just go get a first pass, and go figure how many iterations are needed.

[github-actions]

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

If you want to participate in our support prioritization meetings or be notified when support sprints are happening, you can sign up the support sprint notification emails here.

Read more about our support processs here

[oleg-alexandrov]

Would be nice if this is fixed. Would make it much faster to run the tests, saving hours. The suggested fix seems to be rather easy.

[Kelvinrr]

I'll get this added onto the support board

[amystamile-usgs]

Camstats has a built in option to increase the increments of lines and samples. This is linc and sinc. So the easiest fix would be to change the test to use linc=10 and sinc=10 but then this test would no longer be testing default parameters (linc and sinc defaults are 1). Another option could be to reduce the input cube's line/sample so CameraStatistics isn't iterating 1,273,685 times. @Kelvinrr do you have any thoughts on this?

[Kelvinrr]

@amystamile-usgs I would reduce the size if possible