Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System Wide Alert - adding the contextual help #3958

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

System Wide Alert - adding the contextual help #3958

wants to merge 1 commit into from

Conversation

Andrea-Guevara
Copy link
Contributor

References

Description

Addition of the contextual help feature via the “*dsContextHelp” directive to the “system-wide-alert-form” component.

Instructions for Reviewers

List of changes in this PR:

  • Following the example of other components in which contextual help was implemented, the “*dsContextHelp” directive was imported into ts and used in the html of the “system-wide-alert-form” component.
  • New translation keys have been created.

Include guidance for how to test or review your PR.

  1. Click on the contextual help button to the right of the language selection in the header.
  2. Read the contextual help text that will appear in the headings.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Andrea-Guevara Andrea-Guevara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Accessibility] Implement Contextual Help Tooltips site wide
1 participant
@Andrea-Guevara