Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfilling bootstrap v4.0.0 #164

Merged
merged 188 commits into from
Feb 9, 2018
Merged

Backfilling bootstrap v4.0.0 #164

merged 188 commits into from
Feb 9, 2018

Conversation

sesemaya
Copy link
Contributor

@sesemaya sesemaya commented Feb 9, 2018

No description provided.

Since Material Design does not provide specific guidlines regarding this, I am changing this to stay in line with default Bootstrap.
Add jqeury and popper as peer dependecies
…eta.2

Backfilling bootstrap v4.0.0 beta.2
@sesemaya sesemaya merged commit 9fcc263 into master Feb 9, 2018
@djibe
Copy link

djibe commented Feb 12, 2018

Love it !
Thanks

@djibe
Copy link

djibe commented Feb 12, 2018

Ripple - wave-effect (waves-attach) are not present anymore ?

@sesemaya
Copy link
Contributor Author

Hi @djibe waves have been removed from the latest version (by the way, textarea auto resize is removed, too). The reason is that these third party plugins can be used without any modifications, unlike pickadate as its CSS and JavaScript have to be modified to work with Material. Leaving out these third party plugins can 1) bring down the size of the CSS and JavaScript of this project a bit, 2) provide some flexibility for developers to use their preferred waves plugin. Having said that, the initial idea included a migration doc covering these changes but I was not able to write that up in time of the stable v4 release.

In the meantime, a quick guide here:

@sesemaya
Copy link
Contributor Author

Hi @djibe I have created #167 to track migration doc progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants