Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the expected behavior when settings.get().streaming.text.defaultEnabled is true? #4531

Open
riksagar opened this issue Jul 19, 2024 · 7 comments
Milestone

Comments

@riksagar
Copy link

riksagar commented Jul 19, 2024

Hi,

I'm dealing with a multiperiod stream. The main content has a text track, but the ad breaks don't have a text track. This is a SSAI live stream.

I notice, when we come out of ad break, that the captions automatically enable themselves.

If I've manually turned off captions before the ad break, they will still reenable themselves after the ad break.

I notice that, in the TextController.js, it checks to see if a track was already current, but doesn't check to see if the track was showing.

Should that logic in _onTextTracksAdded() be checking the showing/hidden state of currentTrack?

I notice allTracksAreDisabled is always cleared and lastEnabledIndex is always set to current index (even if it was previously -1

@riksagar
Copy link
Author

riksagar commented Jul 19, 2024

Oh, the captions track in question is a 608/708 track. Not sure if that'd make any difference.

I think this call to setTextTrack() is what re-enables the captions.

@dsilhavy
Copy link
Collaborator

@riksagar Thanks, can you provide your content to reproduce the issue?

@riksagar
Copy link
Author

Hi Daniel,
If you're in the US you can see the behavior on some of our live production channels. For example: this one.

Not sure if our web player is accessible from Germany though. What do you want to look at? Did you just want to look at the MPDs or are you trying to repro the behavior?

@riksagar
Copy link
Author

riksagar commented Jul 23, 2024

As a work around, I'm experimenting with setting the following before starting playback:
dashPlayer.updateSettings({ streaming: { text: { defaultEnabled: false } } });

This fixes (hides?) the problem. I've not seen any side effects.

@dsilhavy
Copy link
Collaborator

Thanks @riksagar I cant access the link you pasted above. I would like to reproduce the issue in one of the next milestones. I will check if we have similar testcontent in our testvector database.

@riksagar
Copy link
Author

Hi Daniel,

We're working on a stream that's not geolocked, so you can try repro.

Regards,
Rik.

@dsilhavy
Copy link
Collaborator

Hi Daniel,

We're working on a stream that's not geolocked, so you can try repro.

Regards, Rik.

Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants