fix: removed hca specific config from lungmap (#4287) #4295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frano-m
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Niiiice thank you @jpaten !
frano-m
reviewed
Nov 27, 2024
frano-m
reviewed
Nov 27, 2024
| } as ListConfig<SamplesResponse>, | ||
| listView: { | ||
| subTitleHero: hcaSubTitleHero, | ||
| }, |
There was a problem hiding this comment.
Hi @jpaten, would you mind removing the listView from samplesEntityConfig lines 207-209.
frano-m
reviewed
Nov 27, 2024
Comment on lines
258
to
260
| listView: { | ||
| subTitleHero: hcaSubTitleHero, | ||
| }, |
There was a problem hiding this comment.
Hi @jpaten would you mind removing listView from the projectsEntityConfig; lines 258-260.
frano-m
reviewed
Nov 27, 2024
| id: HCA_DCP_CATEGORY_KEY.FILE_NAME, | ||
| }, | ||
| } as ListConfig<FilesResponse>, | ||
| listView: { |
There was a problem hiding this comment.
Hi @jpaten would you mind removing listView from filesEntityConfig. Thank you!
MillenniumFalconMechanic
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Hi @jpaten, this is looking good - thank you! I have one change request and then I think it should be good to go.
frano-m
approved these changes
Dec 3, 2024
MillenniumFalconMechanic
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #4287 .
Reviewers
@frano-m .
Changes