Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added test string to diagnose click failures (#4329) #4330

Merged
merged 8 commits into from
Jan 8, 2025

Conversation

jpaten
Copy link
Contributor

@jpaten jpaten commented Jan 7, 2025

Ticket

Closes #4329.

Reviewers

@MillenniumFalconMechanic .

Changes

  • Switched .click events to .dispatchEvent("click") to stop test flakiness after the update to Playwright 20.0.0
  • Updated hoverAndGetText to take an arbitrary Playwright locator that will not overlap with a tooltip, to ensure that tooltips are removed
  • Switched the Chromium browser to use branded Chrome as possible fix to MUI errors

@jpaten jpaten linked an issue Jan 7, 2025 that may be closed by this pull request
@github-actions github-actions bot added the canary Done by the Clever Canary team label Jan 7, 2025
@jpaten jpaten marked this pull request as ready for review January 8, 2025 00:41
Copy link
Collaborator

@NoopDog NoopDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jpaten

@NoopDog NoopDog merged commit e5b579e into main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing E2E tests
2 participants