feat!: remove terra functionality from authprovider into its own provider (#178) #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frano-m
force-pushed
the
fran/178-auth-providers
branch
from
63c9231 to
dd975b7
Compare
frano-m
commented
Oct 24, 2024
There was a problem hiding this comment.
SessionController required for populating the generic auth-related reducers with session from next-auth.
frano-m
commented
Oct 24, 2024
There was a problem hiding this comment.
Terra profile is now separated from the now deleted authentication hook.
frano-m
commented
Oct 24, 2024
| onClose: () => void; | ||
| onDisableScrollLock: () => void; | ||
| onEnableScrollLock: () => void; | ||
| onOpen: (event: MouseEvent<HTMLElement>) => void; | ||
| onToggleOpen: (event: MouseEvent<HTMLElement>) => void; | ||
| onOpen: (event: MouseEvent<E>) => void; |
There was a problem hiding this comment.
Updated the useMenu hook to take a generic E to support use by both Mui Popper and Menu.
frano-m
commented
Oct 24, 2024
There was a problem hiding this comment.
New terra related provider!
hunterckx
changed the title
frano-m
force-pushed
the
fran/178-auth-providers
branch
from
0d2c2f5 to
a05f0dc
Compare
|
Hi @hunterckx, can you rebase this, please? Thanks! |
hunterckx
force-pushed
the
fran/178-auth-providers
branch
from
a05f0dc to
1205650
Compare
frano-m
force-pushed
the
fran/178-auth-providers
branch
from
1205650 to
92ea9ed
Compare
frano-m
force-pushed
the
fran/178-auth-providers
branch
from
92ea9ed to
e26e450
Compare
added 9 commits
January 5, 2025 17:55
frano-m
force-pushed
the
fran/178-auth-providers
branch
from
41a3d58 to
25ede59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #178.