[windows][services] infra, apm, process agents delayed start #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
approved these changes
Feb 21, 2018
truthbk
added a commit
that referenced
this pull request
Feb 21, 2018
arbll
pushed a commit
that referenced
this pull request
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets the services for all three agents as
Automatic (delayed start)services to mitigate known go windows issues with 1.9.2: golang/go#23479Services now will come up, but only after all other services start. This extends the window after restarts when we are not collecting metrics.
Motivation
Services would not restart across reboots on
Automaticservices, they would timeout before coming up and the service control manager would give up spawning them.Additional Notes
It would be nice to get @derekwbrown input regarding reverting this behavior on subsequent releases - it looks trivial, harmless to do so, but it would be nice to get his opinion.