Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vitals Default Presets #1043

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Fix Vitals Default Presets #1043

merged 2 commits into from
Nov 8, 2022

Conversation

maxep
Copy link
Member

@maxep maxep commented Nov 8, 2022

What and why?

Fix vitals presets and align with Android.

Requirements

  • Default Vitals Frequency: average (every 500ms)
  • Frozen Frame Threshold: 700ms

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@maxep maxep self-assigned this Nov 8, 2022
@maxep maxep requested a review from a team as a code owner November 8, 2022 08:22
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 8, 2022 •
edited
Loading

Datadog Report

Branch report: maxep/fix-vitals-defaults
Commit report: 932fc7c

✅ dd-sdk-ios 0 Failed, 0 New Flaky, 2 Passed, 0 Skipped, 402.9ms Wall Time

ncreated
ncreated approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 👌

@maxep maxep merged commit fdd76f1 into release/1.13.0 Nov 8, 2022
@maxep maxep mentioned this pull request Nov 8, 2022
Merged
6 tasks
@maxep maxep deleted the maxep/fix-vitals-defaults branch March 6, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

Assignees

@maxep maxep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxep @ncreated