-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash in NWPathMonitor.current.getter #110
Comments
Here's a fuller report from the Xcode organizer:
|
@LeffelMania huge thanks for this reports and so much details 🙌 ❤️. I think this clearly points us to the conclusion of We're on it, the fix will be released soon. |
Thanks for following up. Do you plan to ship your next milestone this week? We're planning to release our next version as well and would love to update our DD pod before doing so. Looks like the current milestone work is approved https://github.com/DataDog/dd-sdk-ios/milestone/3, so just wondering what the turnaround time might be for a new release. Cheers. |
@LeffelMania Yes, the release scope is closed and I just opened #114. If everything goes smooth, we should release it tomorrow (today is a bank holiday in 🇫🇷 so I can't do much 🙂). |
@LeffelMania 1.2.0 was just released 🚀. That would be very helpful to hear back from you in the future if this crash is gone 🙏. |
@ncreated It's still early in our rollout, but it appears the issue has been resolved; not seeing anything from DataDog in our crash reports. Thanks! |
@LeffelMania Great to hear that back 👌! Thanks for the update and all your input - it was extremely helpful. Let us know in case of any problems 🙂. |
Describe what happened
We have a series of crashes in Firebase that point to different lines in
NWPathMonitor.current
.Steps to reproduce the issue:
Have not reproduced locally, based only on crash reports.
Expected behaviour:
Does not crash.
Actual behaviour:
Crashes.
Additional context
Stack Traces
There are 4 or 5 other identical crashes that point to different line numbers in
NWPathMonitor.swift:<Line>
. Lines include 22, 15, 24, and 16 (in order of crash frequency).This is our most prominent crash currently and we'd love to have it resolved soon. Cheers.
The text was updated successfully, but these errors were encountered: