Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apple Privacy Manifest - add NSPrivacyAccessedAPICategorySystemBootTime #1749

Closed
gabriellupu opened this issue Mar 26, 2024 · 6 comments

Comments

@gabriellupu
Copy link

Feature description

DatadogCore is calling systemUptime() method that according to Apple Docs needs to be reflected in the privacy manifest file as NSPrivacyAccessedAPICategorySystemBootTime

Proposed solution

<key>NSPrivacyAccessedAPITypes</key>
<array>
  <dict>
    <key>NSPrivacyAccessedAPIType</key>
    <string>NSPrivacyAccessedAPICategorySystemBootTime</string>
    <key>NSPrivacyAccessedAPITypeReasons</key>
    <array>
      <string>35F9.1</string>
    </array>
  </dict>
</array>

Other relevant information

No response

@gabriellupu
Copy link
Author

closed since this belongs in Kronos dependency

@maxep
Copy link
Member

maxep commented Mar 26, 2024

Hey @gabriellupu 👋

Did you get any warning from Apple?
Because TimeFreeze.systemUptime() in Kronos is different from ProcessInfo.processInfo.systemUptime, only the later one needs to be declared.

@gabriellupu
Copy link
Author

hey @maxep 👋🏻 thanks a lot for the quick feedback!
Yes we got a NSPrivacyAccessedAPICategorySystemBootTime warning from AppStore.
Unfortunately Apple warning is not pointing the source of the warning so auditing the code looks like that would be the only place in our codebase where we have anything related to systemUptime.

@maxep
Copy link
Member

maxep commented Mar 26, 2024

Thanks! Looks like Apple is only checking the signature, not the actual symbol.
We should probably add it to our manifest or change the signature so I'm reopening this ticket. In the meantime, you can add it to your app manifest, it should silent the warning.

@tdraper-dev
Copy link

Thanks for your efforts! Any updates on when this will be cut for release?

@ncreated
Copy link
Member

👋 2.10.0 is out and it contains the fix to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants