RUMM-611 Hotfix App Store submission issues for DatadogObjc

[ncreated]

What and why?

🐛 This PR is addressing #177 where App Store Connect validation issues are reported when uploading the app that links DatadogObjc with Carthage:

How?

The reason of duplicated framework and colliding com.datadoghq.Datadog bundle identifier was a mistaken configuration of DatadogObjc "Frameworks and Libraries", where Datadog.framework was embedded and signed.

I changed it to not embed the Datadog.framework (as Carthage users do embed it through Carthage script):

I made sure that Objective-C app linking this branch with Carthage passes the ASC validation:

Review checklist

• Feature or bugfix MUST have appropriate tests (unit, integration)
• Make sure each commit and the PR mention the Issue number or JIRA reference

[buranmert]

1. even though there are 2 different Info.plists and bundle identifiers, it collides if framework is embedded?
2. how can we declare DDObjC depends on DD for carthage users as it requires user action now? maybe a mention in README or docs?

[ncreated]

@buranmert

1. even though there are 2 different Info.plists and bundle identifiers, it collides if framework is embedded?

Yes, because DatadogObjc.framework was embedding the Datadog.framework, the Datadog.framework was bundled into app.ipa twice:

app.ipa
|-- Datadog.framework
|-- DatadogObjc.framework
    |-- Frameworks/Datadog.framework

Now it is:

|-- Datadog.framework
|-- DatadogObjc.framework

2. how can we declare DDObjC depends on DD for carthage users as it requires user action now? maybe a mention in README or docs?

DatadogObjc has the setting of "Link but do not embed Datadog.framework", so it won't compile if Datadog.framework is not provided. The Carthage instruction says: "drag and drop each framework you want to use from the Carthage/Build folder on disk", so this should be obvious for the users to include all Datadog frameworks - at least the reporter of this GH Issue got it right. We don't have docs variant for DatadogObjc, so for now there is no good place to explain Objc-related hints.

[buranmert]

if they forget to add Datadog it won't compile with a meaningful error message, so it shouldn't be a problem then 👍
otherwise we could mention this dependency in DatadogObjC.swift file as a comment