RUMM-976 GH Issue #363 #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buranmert
force-pushed
the
buranmert/RUMM-976-parent-baggageItems-fix
branch
3 times, most recently
from
189c9fb
to
89c2476
Compare
ncreated
requested changes
Jan 12, 2021
| @@ -49,7 +49,7 @@ internal class BaggageItems { | |||
| } | |||
|
|
|||
| func get(key: String) -> String? { | |||
| queue.sync { self.unsafeItems[key] } | |||
| queue.sync { self.unsafeItems[key] } ?? parent?.get(key: key) | |||
There was a problem hiding this comment.
This read isn't atomic and blocks the thread several times:
queue.sync { ... } ?? queue.sync { ... } ?? queue.sync { ... } ?? ... Ndepending on how many N parent contexts there are in the hierarchy.
We can make it atomic and ensure there's only one thread sync (queue.sync { ... }) executed if we just do:
queue.sync { self.unsafeAll[key] }As unsafeAll doc comment says, it:
Returns all baggage items for the span, including its parent items.
BaggageItems.get(key) searches in parent.baggageItems too
buranmert
force-pushed
the
buranmert/RUMM-976-parent-baggageItems-fix
branch
from
89c2476
to
034ed84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363
What and why?
Baggage items were not propagated to span's children
A great explanation can be found in #363
How?
Now
BaggageItems.get(key)searches inparent.baggageItemsrecursivelyReview checklist