-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-788 Add data scrubbing API #367
Conversation
15e180c
to
fdf4624
Compare
) | ||
) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use model generator to create these mocks too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of this, but it took me ~10 min
to do it by hand, while adding this in rum-models-generator
would be at least few hours. Let's see how difficult would it be to maintain this hand-made mocks, if too expensive, we can invest our time in rum-models-generator
👌.
What and why?
🚚 This PR adds RUM events scrubbing feature with set of 4 new public APIs:
Each API allows the user to inspect and modify RUM events before they get send. Returning
nil
drops the event.How?
A basic interface of
EventMapper
is introduced:and plugged into
DataProcessor's
pipeline, just before writing the event to the file.It is implemented by
RUMEventsMapper
which intercepts each value using closures configured by the user in the public interface.In the next PR I will also add test scenario to
Example
application with the integration test for scrubbing API.Review checklist