RUMM-1104 Add SpanEvent scrubbing API - implement event mapper
#481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nisations It also makes `DDSpan` fields private, as there is no point of reading them anywhere else in the SDK codebase.
ncreated
commented
May 4, 2021
| /// The equatabiliity is determined based on comparing type mirrors and values. | ||
| protocol EquatableInTests: Equatable {} | ||
|
|
||
| extension EquatableInTests { |
There was a problem hiding this comment.
💡 This new implementation of EquatabeInTests is way smarter than the previous one. The old one was just comparing String(describing: lhs) vs String(describing: rhs), which was not working with unordered collections like [String: Encodable] or Set<AnyHashable>. Now, the comparison looks into each value's Mirror and decides on the equality using reflection 👌.
buranmert
approved these changes
May 5, 2021
…bbing-for-span-events-part4 RUMM-1104 Add `SpanEvent` scrubbing API - cleanup
ncreated
merged commit 23e9f4b
into
ncreated/RUMM-1104-add-data-scrubbing-for-span-events-part2
ncreated
deleted the
ncreated/RUMM-1104-add-data-scrubbing-for-span-events-part3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR adds the actual implementation of
SpanEventsscrubbing - theSpanEventsmapper API:How?
Similar to how RUM events mapper works, the mapper is set up from public interface and passed to the
SpanBuilderthroughFeaturesConfigurationstructure. If the mapper is configured, the builder asks it for redacted version of theSpanEvent.This required making
SpanEventpublic along with some of its dependencies (notablyNetworkConnectionInfoandCarrierInfo).Review checklist