RUMM-1397 Update Endpoints #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buranmert
approved these changes
Jun 21, 2021
| public static func eu1() -> DDEndpoint { .init(sdkEndpoint: .eu1) } | ||
|
|
||
| @objc | ||
| public static func us1_fed() -> DDEndpoint { .init(sdkEndpoint: .us1_fed) } |
There was a problem hiding this comment.
we have DDLogsEndpoint / DDTracesEndpoint but we don't have DDRUMEndpoint, did we forget it or should we deprecate DDLogsEndpoint / DDTracesEndpoint as well?
There was a problem hiding this comment.
Both set(logsEndpoint: DDLogsEndpoint) and public func set(tracessEndpoint: DDLogsEndpoint) were deprecated when introducing common func set(endpoint: DDEndpoint). Enum cases were not deprecated, but they could be.
xgouchet
force-pushed
the
xgouchet/RUMM-1397/update_endpoint
branch
from
dd73253
to
1041d07
Compare
xgouchet
force-pushed
the
xgouchet/RUMM-1397/update_endpoint
branch
from
1041d07
to
4ff0cd8
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Update the endpoints available in the SDK and mark previous ones as deprecated.
Review checklist