Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-1454 fix RUM view path #534

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

xgouchet
Copy link
Member

@xgouchet xgouchet commented Jul 6, 2021

What and why?

Fix discrepancy with Android view path/url.

How?

We keep the key used to start a RUM View as a view url/path. This way if the user provides a name, we still have a technical url which won't change based on localisation, app version etc…

@xgouchet xgouchet requested a review from a team as a code owner July 6, 2021 07:42
@xgouchet xgouchet changed the base branch from master to release/1.7.0-beta1 July 6, 2021 07:55
@buranmert
Copy link
Contributor

DatadogIntegrationTests/Scenarios/RUM/RUMManualInstrumentationScenarioTests.swift:102 failed ❌

XCTAssertEqual(view3.path, "SendRUMFixture3View")

@xgouchet xgouchet force-pushed the xgouchet/RUMM-1454/RUM_view_path branch from b9a9d59 to 1b3d92d Compare July 6, 2021 13:33
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@xgouchet xgouchet merged commit 1b68fec into release/1.7.0-beta1 Jul 7, 2021
@xgouchet xgouchet deleted the xgouchet/RUMM-1454/RUM_view_path branch July 7, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants