RUMM-1492: Fix isSystemImage detection
#563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In device, user images can be in /Bundle/Application/ only. Otherwise, it is a system image. In simulator, system image can be in Xcode.app/Contents/Developer/Platforms only. Otherwise, it is a user image.
buranmert
force-pushed
the
buranmert/RUMM-1492-fix-isSystemImage-v2
branch
from
d74d3a8
to
12ef7a5
Compare
ncreated
approved these changes
Aug 13, 2021
ncreated
pushed a commit
that referenced
this pull request
Sep 27, 2021
…Image-v2 RUMM-1492: Fix `isSystemImage` detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
isSystemImageis important for crash report symbolication at the backend.However, it's a bit tricky tell system images from user images.
In simulator
User images can be found in
MyApp.appbundle orDerivedDatafolder (which is customizable)System images can only be found in
Xcode.appbundle.In device
System images can be found in various places, such as
usr/lib/System/Library/User images can only be found in
MyApp.appbundle.How?
We implemented 2 different logic based on the platform: simulator or device.
However, we test both in our unit tests.
Review checklist