RUMM-346 Fix "device out of memory" crash #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncreated
force-pushed
the
ncreated/RUMM-346-fix-crash-on-device-out-of-memory
branch
3 times, most recently
from
6ccda27
to
d90ce51
Compare
ncreated
changed the base branch from
master
to
ncreated/RUMM-346-add-cocoapods-test
buranmert
suggested changes
Apr 6, 2020
ncreated
force-pushed
the
ncreated/RUMM-346-fix-crash-on-device-out-of-memory
branch
from
af6b6e1
to
d0ec66e
Compare
ncreated
changed the base branch from
ncreated/RUMM-346-add-cocoapods-test
to
ncreated/RUMM-346-unify-dependency-manager-tests
ncreated
force-pushed
the
ncreated/RUMM-346-fix-crash-on-device-out-of-memory
branch
from
d0ec66e
to
e35651b
Compare
DDPrivate module is created to use ObjC from Swift It is not intended for public use We used private.modulemap to hide it from public
ncreated
force-pushed
the
ncreated/RUMM-346-fix-crash-on-device-out-of-memory
branch
from
e175a16
to
cc00074
Compare
buranmert
approved these changes
Apr 6, 2020
ncreated
changed the base branch from
ncreated/RUMM-346-unify-dependency-manager-tests
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
🚚 This PR provides a fix for crash reported in #58 where
NSFileHandleOperationExceptionwas thrown on devices with high memory and disk pressure when writing the log to file.How?
The exception was thrown when calling
write(_ data:)method onFileHandle. This was expected behaviour described by Apple:Unfortunately Apple doesn't provide
throwablevariant offileHandle.write(_:)so we have to catch this error from Objective-C code (until better API is provided in iPhone SDK).This PR introduces
ObjcExceptionHandlerwhich catchesNSExceptionand rethrows it asSwift.Error.Most effort in this PR focuses on introducing separate Objective-C module that we can interoperate with from Swift code and making this module compatible with Carthage, Cocoa Pods and SPM.
Review checklist