SwiftUI Instrumentation #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ea81936.
…vigation RUMM-1745 Use single handler for UIKit and SwiftUI views instrumentation
Co-authored-by: Maciek Grzybowski <[email protected]>
RUMM-1658 Manual instrumentation of SwiftUI actions
ncreated
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
I gave it one more validation round using my SwiftUI side project. It was very easy to instrument and seems to work fine - both views and actions. I think we ship a really good set of APIs with this PR 💪, nice job 🏆💯!
Leaving approval, as all these efforts were already qualified 👌.
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftUI Instrumentation
Add support for
SwiftUImanual instrumentation of views and actions.Merge the following feature PRs into
master:UIApplicationDidBecomeActiveNotification#642RUMCommandPublisherto publish RUM command to a subscriber #649RUMAutoInstrumentationtoRUMInstrumentation#652