RUMM-1779 Keep view active until all resources are consumed #702
Conversation
| XCTAssertEqual(event.model.view.resource.count, 1, "View should record 1 successful Resource") | ||
| XCTAssertEqual(event.model.view.error.count, 1, "View should record 1 error due to second Resource failure") | ||
| XCTAssertFalse(event.model.view.isActive ?? true, "View should be inactive") | ||
| } |
There was a problem hiding this comment.
This test looks good 👍, although we could also test that "SDK doesn't send view updates to completed views (to ones which received their terminal, view.isActive == false update)". How about enhancing session-level validators in RUMSessionMatcher to also integrate this assertion? It already has the notion of ViewVisit aggregating all view updates in their time order and even applying some preliminary isActive checks.
We use RUMSessionMatcher in all integration and many unit tests, so this validation would be heavily applied.
There was a problem hiding this comment.
Yes, I can have a look!
So we would basically stop sending view updates once the view is inactive?
What is the actual definition of an active view?
I worry if BE start processing inactive view events in the future, we will loose data.
There was a problem hiding this comment.
So we would basically stop sending view updates once the view is inactive?
This is exactly how I understand it 👍, but maybe @xgouchet can confirm this.
What is the actual definition of an active view?
I will share more context on Slack.
There was a problem hiding this comment.
I need further modification to actually prevent from sending update events after a view is inactive, here it just sets is_active: false
It's actually already done here, so it's just a matter of asserting this in test as you mentioned!
|
|
What and why?
Backend stop processing view updates when one view reports
is_active: false.How?
Only send the attribute
is_active: falseafter ongoing resources are consumed.Review checklist