-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-1744 Embed Kronos directly into SDK (combined merge) #708
Merged
ncreated
merged 15 commits into
master
from
ncreated/RUMM-1744-embed-Kronos-directly-into-SDK
Jan 5, 2022
Merged
RUMM-1744 Embed Kronos directly into SDK (combined merge) #708
ncreated
merged 15 commits into
master
from
ncreated/RUMM-1744-embed-Kronos-directly-into-SDK
Jan 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heir access control
…ode-to-SDK RUMM-1744 Copy Kronos code to SDK
so it can be monitored in nightly runs.
…nos-tests RUMM-1744 Add E2E tests for Kronos (NTP)
to simplify assertion of GH asset content
…e-tool-to-conditionally-include-Kronos RUMM-1744 Update release tool to conditionally validate `Kronos.xcframework`
maxep
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and approved in linked PRs 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 Combined merge of embedding Kronos into our SDK directly. Includes:
Kronos.xcframework
#704How?
Combined merge of feature branch, no other changes.
Review checklist