Integration with CI Visibility tests #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 22, 2022 09:08
RUM is now able to detect if its being run inside a test instrumented with CI Visibility and perform the following changes then: * Sets `session.type` to `ci_test` * Injects `ci_visibility.test_execution_id` to every event * Set `_dd.origin` to `ciapp-test` so that APM traces from RUM in CI Visibility mode can be distinguished. * Send a message to a Mach Port initialized in the CI Visibility framework (TestMachPort) to notify RUM is enabled * Creates a new Mach Port (RUMMachPort) that will receive a message when the test ends. RUM will flush the RUM events when the message is received.
…` value when setting instead of in initialisation. Fix some tests
|
Very nice use of Also, I'm fine with exposing flushing methods internally 👍 |
ncreated
reviewed
Feb 23, 2022
ncreated
reviewed
Feb 23, 2022
ncreated
reviewed
Feb 23, 2022
ncreated
reviewed
Feb 23, 2022
ncreated
reviewed
Feb 23, 2022
added 4 commits
February 23, 2022 16:15
- Modify CITestIntegration to be object oriented - Change a messageID value to be a bit more descriptive - Fix some tests
Add a test to validate CITestIntegration is off by default
urseberry
reviewed
Mar 8, 2022
docs/trace_collection.md
Outdated
|
|
||
| **Note**: Tracing auto instrumentation uses `URLSession` swizzling, but it is opt-in: if you do not specify `firstPartyHosts`, no swizzling is applied. | ||
| **Note**: Tracing auto-instrumentation uses `URLSession` swizzling and is opt-in. If you do not specify `firstPartyHosts`, swizzling is not applied. |
There was a problem hiding this comment.
Is "swizzling" defined elsewhere, or is it a commonly understood term? It is a bit confusing to me, but this is outside my normal subject area.
There was a problem hiding this comment.
Yes, is a commonly understood term in iOS programming. Anyway this change was not supposed to be here so I reverted it
urseberry
approved these changes
Mar 8, 2022
nachoBonafonte
force-pushed
the
CI-APP-RUM-Integration
branch
from
58a0381
to
62928a2
Compare
This was referenced Apr 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
This PR enables a much deeper integration of RUM with CI Visibility product (dd-sdk-swift-testing). If a UI test instrumented with CI Visibility is run and a RUM sessions is configured, the session will be identified as a created by CI App and will be shown as part of the test.
There is a related PR with the needed changes in the dd-sdk-swift-testing framework
How?
RUM now detects on loading if is running under an instrumented test by checking if the environment variable
CI_VISIBILITY_TEST_EXECUTION_IDis available, which contains the test identifier. If so it makes the following changes:session.typetoci-testci_visibility.test_execution_idto every event_dd.origintociapp-testso that APM traces from RUM in CI Visibility mode can be distinguished.Review checklist