Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-1803 Stop reporting pre-warmed application launch time #789

Merged
merged 3 commits into from
Mar 24, 2022

Conversation

maxep
Copy link
Member

@maxep maxep commented Mar 23, 2022

What and why?

Don't report launch time for pre-warmed process.

RFC 2353430547

How?

// isActivePrewarm = [NSProcessInfo.processInfo.environment[@"ActivePrewarm"] isEqualToString:@"1"];

BOOL __dd_private_isActivePrewarm() {
    if (isActivePrewarm) return isActivePrewarm;
    CFTimeInterval time = __dd_private_AppLaunchTime();
    return time > ValidAppLaunchTimeThreshold;
}

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing change.

@maxep maxep requested a review from a team as a code owner March 23, 2022 14:37
@maxep maxep merged commit e9a91fb into develop Mar 24, 2022
@maxep maxep deleted the maxep/RUMM-1803/report-active-prewarm branch March 24, 2022 11:20
@maxep maxep self-assigned this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants