-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-2166 Add tracing sampling rate #851
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf76409
to
a907a6d
Compare
maxep
commented
May 12, 2022
I'm targeting the |
a907a6d
to
ccb8298
Compare
ccb8298
to
73fb475
Compare
73fb475
to
5c9fa6f
Compare
ncreated
reviewed
May 13, 2022
Sources/DatadogObjc/Tracing/Propagation/HTTPHeadersWriter+objc.swift
Outdated
Show resolved
Hide resolved
a776ae2
to
9fde6d7
Compare
9fde6d7
to
5b7c435
Compare
cswatt
requested changes
May 13, 2022
Co-authored-by: cswatt <[email protected]>
4e30ef2
to
7366761
Compare
0a1f09d
to
f8b9787
Compare
ncreated
approved these changes
May 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! ✅
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Offer a configuration option to set the tracing sampling rate. Based on this sampling rate, new network requests will have the
x-datadog-sampling-priority
header set to 0 (or 1 accordingly), and thetrace_id
andspan_id
won’t (or will accordingly) be added to the created RUM Resource.Note: The
x-datadog-sampled
is now removed.When sampled out, a RUM resource appears with no trace:
How?
The
HTTPHeadersWriter
now expect asamplingRate
value at initialization. If the rate is 0, the trace id and span id are not propagated to APM nor RUM when instrumentingURLSession
. Thex-datadog-sampling-priority
is set accordingly when a request is intercepted.The
samplingRate
is configured by theFeaturesConfiguration.URLSessionAutoInstrumentation
and injected toURLSessionInterceptor
at initialization.Review checklist
Custom CI job configuration (optional)