RUMM-2173 Add log level threshold option #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
force-pushed
the
xgouchet/RUMM-2173/log_filter
branch
from
630d8ff
to
7b83ccc
Compare
buraizu
requested changes
May 25, 2022
docs/log_collection.md
Outdated
| .build() | ||
| ``` | ||
| {{% /tab %}} | ||
| {{% tab "Objective-C" %}} | ||
| ```objective-c | ||
| DDLoggerBuilder *builder = [DDLogger builder]; | ||
| [builder sendNetworkInfo:YES]; | ||
| [builder setWithDatadogReportingThreshold:.info] |
There was a problem hiding this comment.
It looks like there may be a missing semicolon at the end of this line. Could you confirm and update if needed?
ncreated
requested changes
May 26, 2022
Sources/Datadog/Logger.swift
Outdated
Comment on lines
362
to
363
| /// set the minim log level reported to Datadog servers. | ||
| /// Any log with a level equal or above to the threshold will be sent |
There was a problem hiding this comment.
Suggested change
| /// set the minim log level reported to Datadog servers. | |
| /// Any log with a level equal or above to the threshold will be sent | |
| /// Set the minim log level reported to Datadog servers. | |
| /// Any log with a level equal or above to the threshold will be sent. |
xgouchet
force-pushed
the
xgouchet/RUMM-2173/log_filter
branch
from
f384e22
to
c6499e0
Compare
buraizu
approved these changes
May 27, 2022
6 tasks
This was referenced Sep 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Add a way to filter logs per status before they're sent to Datadog.
How?
Added an option in the logger builder, that's passed to the LogFileOutput.
Review checklist