Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public visibility to Internal Proxy methods. #964

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Add public visibility to Internal Proxy methods. #964

merged 1 commit into from
Aug 9, 2022

Conversation

fuzzybinary
Copy link
Member

What and why?

Add public to all the Internal Proxy methods as they need to be public to be useful.

How?

Just add public in front.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@fuzzybinary fuzzybinary requested a review from a team as a code owner August 9, 2022 15:26
maxep
maxep approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fuzzybinary fuzzybinary merged commit 58cff31 into develop Aug 9, 2022
@fuzzybinary fuzzybinary deleted the jward/public_proxy branch August 9, 2022 16:04
This was referenced Sep 16, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxep maxep maxep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuzzybinary @maxep