Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUMM-2508 Fix manual User Action dropped if a new view start #997

Merged
merged 3 commits into from
Sep 16, 2022
Merged

RUMM-2508 Fix manual User Action dropped if a new view start #997

merged 3 commits into from
Sep 16, 2022

Conversation

maxep
Copy link
Member

@maxep maxep commented Sep 15, 2022 •
edited
Loading

What and why?

A user action should be sent if a new view start shortly after.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@maxep maxep self-assigned this Sep 15, 2022
@maxep maxep marked this pull request as ready for review September 15, 2022 12:53
@maxep maxep requested a review from a team as a code owner September 15, 2022 12:53
@maxep maxep changed the title RUMM-2432 Fix manual User Action dropped if new a view start RUMM-2508 Fix manual User Action dropped if new a view start Sep 15, 2022
@maxep maxep force-pushed the maxep/RUMM-2432/fix-user-action-drop branch from 7daf76f to a5f02ca Compare September 15, 2022 12:56
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: maxep/RUMM-2432/fix-user-action-drop
Commit report: a5f02ca

✅ dd-sdk-ios 0 Failed, 0 New Flaky, 1918 Passed, 0 Skipped, 19m51.07s Wall Time

ncreated
ncreated approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯🎯

@maxep maxep changed the title RUMM-2508 Fix manual User Action dropped if new a view start RUMM-2508 Fix manual User Action dropped if a new view start Sep 15, 2022
@maxep maxep merged commit bdcabd2 into release/1.12.0 Sep 16, 2022
@maxep maxep deleted the maxep/RUMM-2432/fix-user-action-drop branch September 16, 2022 06:16
This was referenced Sep 16, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

Assignees

@maxep maxep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxep @ncreated