-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-4313 feat: Add WebViewTracking
for Obj-c
#1854
RUM-4313 feat: Add WebViewTracking
for Obj-c
#1854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
Datadog ReportBranch report: ✅ 0 Failed, 3160 Passed, 0 Skipped, 2m 44.22s Total Time 🔻 Code Coverage Decreases vs Default Branch (4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Just a minor request to align with the convention we agreed on the RFC
import WebKit | ||
#endif | ||
|
||
@objc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/change-request We aim to hide these interfaces from Swift autocompletion. As stated in the RFC, the interfaces should read:
@objc(DDWebViewTracking) @_spi(objc)
public final class objc_WebViewTracking: NSObject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for flagging this 💪! I forgotten that we established this convention. Now everything should be up-to-date, including the PR comment and +objc
file location ✅.
… common convention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you :)
What and why?
📦 This PR adds Objective-C API for
DatadogWebViewTracking
module.How?
Following the convention from RFC - Modular Objective-C Interface.
Review checklist
Custom CI job configuration (optional)
tools/