Inject backtrace reporter into Logs feature #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
changed the title
0xnm
force-pushed
the
nogorodnikov/inject-backtrace-reporter-into-logsfeature
branch
from
968fd94
to
dcb2343
Compare
|
Looks great, nice catch! |
0xnm
force-pushed
the
nogorodnikov/inject-backtrace-reporter-into-logsfeature
branch
from
dcb2343
to
8627775
Compare
|
@maxep I added a simple test. |
0xnm
force-pushed
the
nogorodnikov/inject-backtrace-reporter-into-logsfeature
branch
from
8627775
to
2f117d4
Compare
maxep
approved these changes
Jul 9, 2024
ncreated
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Follow-up for 00fd8f7 - backtrace reporter was added to the Logs feature, but it was never passed in the constructor call.
Review checklist
Custom CI job configuration (optional)