Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-5732 chore: cleanup deprecated podspecs #1998

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Aug 19, 2024

What and why?

We don't want to continue updating the podspec which are no longer active.

How?

  • Remove podspecs
  • Remove update process
  • We are keeping the DatadogAlamofireExtension.podspec as this may introduce a breaking change when customers are auto upgrading the SDK and hit an issue where there is no version for extension. Now they will be forced to update which we only prefer in major versions. By keeping this we are making sure minor upgrades to the SDK are smooth. Meanwhile, the spec is deprecated, and customers are advised to use newer APIs.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

@ganeshnj ganeshnj marked this pull request as ready for review August 19, 2024 09:29
@ganeshnj ganeshnj requested review from a team as code owners August 19, 2024 09:29
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: ganeshnj/feat/drop-cp-specs
Commit report: aebf155
Test service: dd-sdk-ios

✅ 0 Failed, 1864 Passed, 0 Skipped, 1m 15.76s Total Time
⬆️ Test Sessions change in coverage: 1 increased (+0.08%), 7 no change

@ganeshnj ganeshnj merged commit 2776cf4 into develop Aug 26, 2024
17 checks passed
@ganeshnj ganeshnj deleted the ganeshnj/feat/drop-cp-specs branch August 26, 2024 11:49
@mariedm mariedm mentioned this pull request Sep 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants