Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-872 Keep Secured Text Hidden #2050

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Sep 12, 2024

What and why?

UITextInputTraits's isSecureTextEntry and textContentType properties are mutable, meaning that a sensitive texts could be revealed to the end user. e.g.: Revealing a password for verification.

But in Session Replay, we should keep considering the text as sensitive even if it was revealed.

How?

Keep sensitivity in memory using associated object on views conforming to UITextInputTraits.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

@maxep maxep marked this pull request as ready for review September 12, 2024 12:35
@maxep maxep requested review from a team as code owners September 12, 2024 12:35
@maxep maxep force-pushed the maxep/RUM-872/keep-secure-fields-hidden branch from ad36771 to b0918f3 Compare September 12, 2024 12:37
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Sep 12, 2024

Datadog Report

Branch report: maxep/RUM-872/keep-secure-fields-hidden
Commit report: cba150d
Test service: dd-sdk-ios

✅ 0 Failed, 3470 Passed, 0 Skipped, 2m 18.44s Total Time
🔻 Test Sessions change in coverage: 3 decreased, 4 increased, 7 no change

🔻 Code Coverage Decreases vs Default Branch (3)

  • test DatadogSessionReplayTests iOS 30.57% (-0.06%) - Details
  • test DatadogInternalTests iOS 79.48% (-0.05%) - Details
  • test DatadogCoreTests iOS 72.69% (-0.01%) - Details

@maxep maxep changed the title RUM-872 Keeps Secured Text Hidden RUM-872 Keep Secured Text Hidden Sep 12, 2024
mariedm
mariedm previously approved these changes Sep 13, 2024
Copy link
Member

@mariedm mariedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Thank you for taking care of it!

@maxep maxep force-pushed the maxep/RUM-872/keep-secure-fields-hidden branch 2 times, most recently from d2017a0 to c3071c4 Compare September 16, 2024 10:38
@maxep maxep requested a review from mariedm September 16, 2024 10:40
mariedm
mariedm previously approved these changes Sep 16, 2024
@maxep maxep force-pushed the maxep/RUM-872/keep-secure-fields-hidden branch from d2017a0 to cba150d Compare September 16, 2024 11:38
@maxep maxep merged commit 53f5cde into develop Sep 16, 2024
16 checks passed
@maxep maxep deleted the maxep/RUM-872/keep-secure-fields-hidden branch September 16, 2024 12:33
@maciejburda maciejburda mentioned this pull request Sep 24, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants