-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-872 Keep Secured Text Hidden #2050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxep
force-pushed
the
maxep/RUM-872/keep-secure-fields-hidden
branch
from
September 12, 2024 12:37
ad36771
to
b0918f3
Compare
Datadog ReportBranch report: ✅ 0 Failed, 3470 Passed, 0 Skipped, 2m 18.44s Total Time 🔻 Code Coverage Decreases vs Default Branch (3) |
maxep
changed the title
RUM-872 Keeps Secured Text Hidden
RUM-872 Keep Secured Text Hidden
Sep 12, 2024
mariedm
previously approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT! Thank you for taking care of it!
maxep
force-pushed
the
maxep/RUM-872/keep-secure-fields-hidden
branch
2 times, most recently
from
September 16, 2024 10:38
d2017a0
to
c3071c4
Compare
mariedm
previously approved these changes
Sep 16, 2024
maxep
force-pushed
the
maxep/RUM-872/keep-secure-fields-hidden
branch
from
September 16, 2024 11:33
c3071c4
to
d2017a0
Compare
mariedm
approved these changes
Sep 16, 2024
maxep
force-pushed
the
maxep/RUM-872/keep-secure-fields-hidden
branch
from
September 16, 2024 11:38
d2017a0
to
cba150d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
UITextInputTraits
'sisSecureTextEntry
andtextContentType
properties are mutable, meaning that a sensitive texts could be revealed to the end user. e.g.: Revealing a password for verification.But in Session Replay, we should keep considering the text as sensitive even if it was revealed.
How?
Keep sensitivity in memory using associated object on views conforming to
UITextInputTraits
.Review checklist