Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace static:: with self:: for private variables #24

Merged
merged 1 commit into from
Jul 2, 2015
Merged

Replace static:: with self:: for private variables #24

merged 1 commit into from
Jul 2, 2015

Conversation

shadowhand
Copy link
Contributor

Attempting to use static:: to reference a private variable under HHVM will trigger an error:

Fatal error: Invalid static property access in ...

@elafarge
Copy link
Contributor

elafarge commented Jul 2, 2015

Thanks for contributing @shadowhand . It's indeed a bit more correct to use self:: with protected members (or actually useless to use static::). Good catch. I just merged your PR :)

elafarge added a commit that referenced this pull request Jul 2, 2015
@elafarge
Merge pull request #24 from wheniwork/master
b5dd651 
Replace static:: with self:: for private variables
@elafarge elafarge merged commit b5dd651 into DataDog:master Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadowhand @elafarge