Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the _dummify method #16

Open
adedaran opened this issue Jul 12, 2022 · 0 comments
Open

Remove the _dummify method #16

adedaran opened this issue Jul 12, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@adedaran
Copy link
Collaborator

Currently
The Slicefinder class has a _dummify method implementing a one-hot encoding function with an additional argument: n_col_x_encoded. This argument enable to generate extra column of 0 to fit the required shape.

Goal
Remove this method. It is only used in _create_and_score_basic_slices. Maybe sklearn OneHotEncoder can do the job.
@florent-pajot florent-pajot added the enhancement New feature or request label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adedaran @florent-pajot