Skip to content
This repository has been archived by the owner on Jun 11, 2019. It is now read-only.

move configs into their own file #16

Closed
oliviamriley opened this issue Apr 4, 2018 · 2 comments
Closed

move configs into their own file #16

oliviamriley opened this issue Apr 4, 2018 · 2 comments
Labels
enhancement New feature or request project structure wontfix This will not be worked on

Comments

@oliviamriley
Copy link
Collaborator

rn all the default configs are sitting in index.js and it makes it less readable.

we should move them to a separate file (it could just be json, or maybe js and use export or smth).

@oliviamriley oliviamriley added enhancement New feature or request project structure labels Apr 4, 2018
@oliviamriley
Copy link
Collaborator Author

so node.js doesn't natively support import rn, which means we can't just use import/export.
this is the problem with node!! it wasn't meant to be a server-side language so stuff like this is just tacked on.

until node adds this support, we need to either read from JSON (which is ugly and not worth it) or use a transpiler. personally, i don't think this is worth adding another dev dependency when it was supposed to make development easier . im marking this wontfix until node updates.

@oliviamriley oliviamriley added the wontfix This will not be worked on label Apr 15, 2018
@oliviamriley
Copy link
Collaborator Author

updates on this in this issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request project structure wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant