Mapping of internal model variables and parameters to standard names #518
Conversation
Was removed in combination with testing `get_alias`.
to `saturated_hydraulic_conductivity_profile`. Move this key from `config.vertical` to `config.model`.
Just to jump in this discussion here: we indeed decided to reorganize the toml file, so perhaps better to wait with #519 to prevent double work ;) ). |
Rename these parameters to standard names. Additionally, made a start with standard name mapping (external standard name => internal model name). It makes use of `Wflow.param` functionality as much as possible, allowing to write any model output variable with the former TOML keys.
to standard names using `model_boundary_condition` (e.g. CSDMS uses `model_grid_ edge`) as objects.
Use lenses from `Accessors` for mapping standard names and for input parameters (`ncread`). Change parameter names of demand and groundwater to standard names. Writing any model output variable with the former TOML keys is possible (using `param`).
As the `sediment` model type makes use of hydrological forcing timeseries that are stored differently (internally) than the same timeseries used by model types `sbm` and `sbm_gwf`, the standard name mapping is done separately for the `sediment` model type (different dict). The same hydrological forcing data is used by the `SoilLoss` and `OverlandFlowSediment` components. This data is now only stored in the `SoilLoss` component and shared (memory) with the `OverlandFlowSediment` component.
|
Hydrological forcing data in model type Possible improvements:
|
Checking list of standard names (`input.state.variables`).
Issue addressed
Fixes #481
sbm: change model parameters, states, and output variables (sub-selection) to standard names.sbm_gwf: change model parameters, states, and output variables (sub-selection) to standard names.sediment: change model parameters, states, and output variables (sub-selection) to standard names.sediment, see also Mapping of internal model variables and parameters to standard names #518 (comment).standard_name_map).sedimentmodel, not always clear from code/metadata/docs as the unit is also part of the standard name (quantity).