Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and align Model initialization functions #523

Open
vers-w opened this issue Jan 8, 2025 · 0 comments · May be fixed by #528
Open

Refactor and align Model initialization functions #523

vers-w opened this issue Jan 8, 2025 · 0 comments · May be fixed by #528
Labels
v1.0 Activities related to v1.0

Comments

@vers-w
Copy link
Collaborator

vers-w commented Jan 8, 2025

Feature type

Changing existing functionality

Improvement Description

The model initialization functions of model types sbm, sbm_gwf and sediment contain quite some duplicate code (after refactoring, see also issues #486 and #382, and PR #517).

Additionally, the model type sediment makes after refactoring (PR #463) use of LandGeometry and RiverGeometry types to store land and river shared geometry parameters, while for the sbm and sbm_gwf model types these parameters are stored as part of the Model.network and river and overland flow parameter sets. Model types sbm and sbm_gwf can also make use of these geometry types, where these structs are preferably stored at the same level in the Model struct for the different model types.

Implementation Description

No response

Additional Context

No response

@vers-w vers-w added the v1.0 Activities related to v1.0 label Jan 8, 2025
@SouthEndMusic SouthEndMusic linked a pull request Jan 16, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.0 Activities related to v1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant