Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Handle effects #54

Closed
Derpius opened this issue Aug 27, 2022 · 1 comment
Closed

[feature] Handle effects #54

Derpius opened this issue Aug 27, 2022 · 1 comment
Labels
binary module Issues relating to the binary module enhancement New feature or request

Comments

@Derpius
Copy link
Owner

Derpius commented Aug 27, 2022

Is your feature request related to a problem? Please describe.
Effects will render as melons

Describe the solution you'd like
We can't just blindly use the prop_dynamic stored in an effect, as the user may pass those entities explicitly.
The only possible solutions involve disabling rendering of an effect's model, then either requiring the user to explicitly pass the prop_dynamic (easy solution with obvious behaviour), or get the real entity off the effect and check whether the user already passed it explicitly (complex solution and the behaviour is inconsistent depending on whether you pass a dynamic prop along with an effect SENT.

I'll probably go with the former

@Derpius Derpius added enhancement New feature or request binary module Issues relating to the binary module labels Aug 27, 2022
@Derpius Derpius modified the milestone: v1.0.0 Aug 27, 2022
@Derpius
Copy link
Owner Author

Derpius commented Aug 30, 2022

Added in 1a061c2

@Derpius Derpius closed this as completed Aug 30, 2022
@Derpius Derpius moved this to Backlog in VisTrace Dec 16, 2022
@Derpius Derpius added this to VisTrace Dec 16, 2022
@Derpius Derpius moved this from Backlog to Done in VisTrace Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary module Issues relating to the binary module enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant