Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Anisotropic reflections #57

Closed
Derpius opened this issue Sep 3, 2022 · 2 comments
Closed

[feature] Anisotropic reflections #57

Derpius opened this issue Sep 3, 2022 · 2 comments
Labels
binary module Issues relating to the binary module BSDF Issues relating to the VisTrace BSDF enhancement New feature or request
Milestone
v0.12.0

Comments

@Derpius
Copy link
Owner

Derpius commented Sep 3, 2022

Describe the solution you'd like
Replace yocto-gl's isotropic distribution and geometry terms with anisotropic versions.

Additional context
https://jcgt.org/published/0007/04/01/paper.pdf
@Derpius Derpius added enhancement New feature or request binary module Issues relating to the binary module labels Sep 3, 2022
@Derpius Derpius added this to the v1.0.0 milestone Sep 3, 2022
@Derpius
Copy link
Owner Author

Derpius commented Sep 4, 2022

Converting roughness and anisotropy parameters to x and y roughness
image

@Derpius Derpius modified the milestones: v1.0.0, v0.12.0 Sep 9, 2022
@Derpius Derpius added the BSDF Issues relating to the VisTrace BSDF label Sep 15, 2022
@Derpius
Copy link
Owner Author

Derpius commented Sep 15, 2022

After further research it seems there are already established formulas for implementing a mapping from anisotropy+roughness to x and y roughness that are more artist friendly

@Derpius Derpius moved this to Backlog in VisTrace Dec 16, 2022
@Derpius Derpius added this to VisTrace Dec 16, 2022
@Derpius Derpius moved this from Backlog to Done in VisTrace Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binary module Issues relating to the binary module BSDF Issues relating to the VisTrace BSDF enhancement New feature or request
Projects
VisTrace
Status: Done
Milestone
v0.12.0
Development

No branches or pull requests
1 participant
@Derpius