Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename #define BENCHMARK #114

Closed
mloskot opened this issue Feb 15, 2018 · 2 comments
Closed

Rename #define BENCHMARK #114

mloskot opened this issue Feb 15, 2018 · 2 comments
Labels
wontfix

Comments

@mloskot
Copy link
Contributor

mloskot commented Feb 15, 2018

Would it be possible to rename #define BENCHMARK to something more unique?

The generic BENCHMARK clashes with benchmarking feature in Catch2, see catchorg/Catch2#1186
@mloskot mloskot mentioned this issue Feb 15, 2018
Closed
@DigitalInBlue
Copy link
Owner

I'm not going to disagree, but it would break all existing benchmarks to make it more unique at this point.

@mloskot
Copy link
Contributor Author

mloskot commented Mar 10, 2018

I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mloskot @DigitalInBlue