forked from guusw/unnamed-sdvx-clone
-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] cpr compilation errors when using curl v8 #649
Labels
Comments
This was fixed in 76c359f |
Unfortunately this error still occurs on then newest commit (f264d38), now with curl
This is the flake I use: {
inputs = {
nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable";
flake-utils.url = "github:numtide/flake-utils";
};
outputs = { nixpkgs, flake-utils, ... }: flake-utils.lib.eachDefaultSystem (system:
let
pkgs = import nixpkgs {
inherit system;
};
in {
packages.default = pkgs.stdenv.mkDerivation {
name = "unnamed-sdvx-clone";
src = pkgs.fetchFromGitHub {
owner = "Drewol";
repo = "unnamed-sdvx-clone";
rev = "f264d380dd0550a781237028392e68db1ec51478"; # Latest commit (the latest tagged version is from 2021)
sha256 = "sha256-UgdBiASCUbF+UtxgJ0UMH7d1zOKW/y3bXGkAKB/cBEk=";
fetchSubmodules = true;
};
nativeBuildInputs = with pkgs; [
cmake
];
cmakeFlags = [
# If this flag is not enabled, the cpr CMakeLists.txt will try and clone zlib with git at buildtime, which will error out, as the network is disabled during Nix package builds
"-DCPR_FORCE_USE_SYSTEM_CURL=ON"
];
buildPhase = ''
make
'';
installPhase = ''
mkdir -p $out/bin
mv bin $out/bin
'';
buildInputs = with pkgs; [
SDL2
zlib
freetype
libarchive
libogg
libvorbis
libpng # orig is libpng12
libjpeg # orig is libjpeg_original
# rapidjson # required by third_party/discord-rpc
# libgl1-mesa-dev # not sure where to pull this from or if I even need to at this point?
openssl
libiconv
curl # See the explanation for forcing system curl
];
};
}
);
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I'm trying to build unnamed-sdvx-clone via Nix. The version of curl in
nixpkgs
(the package repo for the Nix ecosystem) is version8.2.1
. When trying to build this project, the following error occurs during the build process:This issue seems to have been fixed in a recent version of
cpr
. See:libcpr/cpr#870
libcpr/cpr#890
However, forking this repository, updating the
cpr
submodule, pointing the flake to use the fork as an input, and trying to build gives the following error:To Reproduce
Steps to reproduce the behavior:
flake.nix
with the following content:nix build
Desktop:
The text was updated successfully, but these errors were encountered: